fix workflow status did not updated for failed activity

[SeanHH86]

What is this feature?

bug fix for workflow status did not updated and no readme.md for repo

MR Summary:

The summary is added by @codegpt.

This Merge Request addresses a bug where the workflow status was not updated for failed activities. It also adds missing readme.md documentation to the repository. Key changes include:

1. Modification in error handling to replace WorkflowErr with WorkflowErrMsg as a string to better capture and log workflow errors.
2. Adjustments in workflow and activity implementations to ensure the workflow status is correctly updated upon failure.
3. Updates in test cases to align with the changes in error handling and workflow status updates.
4. Introduction of logging warnings instead of returning errors when readme.md content is invalid or missing, ensuring the workflow continues with default configurations.

These changes aim to enhance error handling and status reporting in the data viewer's workflow management, improving reliability and maintainability.

[starship-github]

Possible Issues And Suggestions:

• Line 226 in dataviewer/workflows/workflow.go
  • Comments:
    • The error message is extracted from wfErr but not used if wfErr is nil. This change might introduce a logical inconsistency if errMsg is expected to have a default value or represent a specific state when wfErr is nil.
• dataviewer/workflows/activity.go
  • Comments:
    • Changing error handling to log warnings and return an empty card data object could suppress critical errors, potentially leading to data inconsistency or loss.
• dataviewer/workflows/activity.go
  • Comments:
    • The change from WorkflowErr to WorkflowErrMsg might not account for cases where an error object provided more context than a string message could.
• Line 172 in dataviewer/common/types.go
  • Comments:
    • Changing WorkflowErr to WorkflowErrMsg simplifies error handling but may lose the stack trace and other error details.

MR Evaluation:

This feature is still under test, evaluation are given by AI and might be inaccurate.

After evaluation, the code changes in the Merge Request get score: 94-96.

Analysis for the evaluation score:

• The code change may not include the corresponding user manual.

Tips

CodeReview Commands (invoked as MR or PR comments)

• @codegpt /review to trigger an code review.
• @codegpt /evaluate to trigger code evaluation process.
• @codegpt /describe to regenerate the summary of the MR.
• @codegpt /secscan to scan security vulnerabilities for the MR or the Repository.
• @codegpt /help to get help.

CodeReview Discussion Chat

There are 2 ways to chat with Starship CodeReview:

• Review comments: Directly reply to a review comment made by StarShip.
  Example:
  • @codegpt How to fix this bug?
• Files and specific lines of code (under the "Files changed" tab):
  Tag @codegpt in a new review comment at the desired location with your query.
  Examples:
  • @codegpt generate unit testing code for this code snippet.

Note: Be mindful of the bot's finite context window.
It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.
For a focused discussion, use review comments to chat about specific files and their changes, instead of using the MR/PR comments.

CodeReview Documentation and Community

• Visit our Documentation
  for detailed information on how to use Starship CodeReview.

About Us:

Visit the OpenCSG StarShip website for the Dashboard and detailed information on CodeReview, CodeGen, and other StarShip modules.

[starship-github]

The StarShip CodeReviewer was triggered but terminated because it encountered an issue: The MR state is not opened.

Tips

CodeReview Commands (invoked as MR or PR comments)

• @codegpt /review to trigger an code review.
• @codegpt /evaluate to trigger code evaluation process.
• @codegpt /describe to regenerate the summary of the MR.
• @codegpt /secscan to scan security vulnerabilities for the MR or the Repository.
• @codegpt /help to get help.

CodeReview Discussion Chat

There are 2 ways to chat with Starship CodeReview:

• Review comments: Directly reply to a review comment made by StarShip.
  Example:
  • @codegpt How to fix this bug?
• Files and specific lines of code (under the "Files changed" tab):
  Tag @codegpt in a new review comment at the desired location with your query.
  Examples:
  • @codegpt generate unit testing code for this code snippet.

Note: Be mindful of the bot's finite context window.
It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.
For a focused discussion, use review comments to chat about specific files and their changes, instead of using the MR/PR comments.

CodeReview Documentation and Community

• Visit our Documentation
  for detailed information on how to use Starship CodeReview.