Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client] add reliability in Report (#opencti/2362) #423

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

SouadHadjiat
Copy link
Member

@SouadHadjiat SouadHadjiat commented Jul 11, 2023

Proposed changes

Linked to PR : OpenCTI-Platform/opencti#3719

  • Add reliability (x_opencti_reliability) field to Report, Individual and System

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

result_data_field = "individualAdd"
elif type == IdentityTypes.SYSTEM.value:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test on it ? (in tests/02-integration/entities)
Thank you

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple test added

@SouadHadjiat SouadHadjiat merged commit eae0609 into master Aug 2, 2023
2 checks passed
@SouadHadjiat SouadHadjiat deleted the opencti/2362 branch August 2, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants