Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix padding in PlaybookAddComponents(#5514) #5604

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

CelineSebe
Copy link
Member

Proposed changes

  • Padding

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@CelineSebe CelineSebe added the filigran team use to identify PR from the Filigran team label Jan 19, 2024
@CelineSebe CelineSebe linked an issue Jan 19, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (91832bc) 66.29% compared to head (b4ad23b) 66.29%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5604   +/-   ##
=======================================
  Coverage   66.29%   66.29%           
=======================================
  Files         508      508           
  Lines       59808    59808           
  Branches     4372     4373    +1     
=======================================
+ Hits        39649    39651    +2     
+ Misses      20159    20157    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelHassine SamuelHassine merged commit 7b5d23c into master Jan 19, 2024
5 checks passed
@SamuelHassine SamuelHassine deleted the issue/5514 branch January 19, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Padding not correct in playbook drawers
3 participants