Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix toggle buttons display in headers (#5599) #5605

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

SouadHadjiat
Copy link
Member

@SouadHadjiat SouadHadjiat commented Jan 19, 2024

Proposed changes

  • Remove toggleButtonGroup in headers since all toggle buttons are independent (replace it with a flex div)
  • Fix knowledge graph header display when banner is displayed

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7293b19) 66.30% compared to head (d7224c0) 66.29%.
Report is 1 commits behind head on master.

❗ Current head d7224c0 differs from pull request most recent head 4651f91. Consider uploading reports for the commit 4651f91 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5605      +/-   ##
==========================================
- Coverage   66.30%   66.29%   -0.01%     
==========================================
  Files         508      508              
  Lines       59808    59808              
  Branches     4373     4373              
==========================================
- Hits        39653    39651       -2     
- Misses      20155    20157       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SouadHadjiat SouadHadjiat marked this pull request as ready for review January 19, 2024 10:24
@SamuelHassine SamuelHassine merged commit b94436d into master Jan 19, 2024
3 checks passed
@SamuelHassine SamuelHassine deleted the issue/5599 branch January 19, 2024 10:46
@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants