Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Unauthorized errors should redirect to Login page (#5608) #5609

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

SouadHadjiat
Copy link
Member

@SouadHadjiat SouadHadjiat commented Jan 19, 2024

Proposed changes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

To test this PR

  • Go to settings => security => users => your user => invalidate its session
  • click somewhere else in the app (like "Reports") => you should be redirected to Login page (instead of seeing a "unknown error occurred" message)

@SouadHadjiat SouadHadjiat linked an issue Jan 19, 2024 that may be closed by this pull request
@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (91832bc) 66.29% compared to head (4606c97) 66.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5609      +/-   ##
==========================================
+ Coverage   66.29%   66.30%   +0.01%     
==========================================
  Files         508      508              
  Lines       59808    59808              
  Branches     4372     4373       +1     
==========================================
+ Hits        39649    39655       +6     
+ Misses      20159    20153       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SouadHadjiat SouadHadjiat marked this pull request as ready for review January 19, 2024 13:08
@SamuelHassine SamuelHassine merged commit 6b328c1 into master Jan 19, 2024
5 checks passed
@SamuelHassine SamuelHassine deleted the issue/5608 branch January 19, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unauthorized errors should redirect to Login page
2 participants