Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix respecting case of groups and organizations in header provider #5664

Closed
wants to merge 1 commit into from

Conversation

sbocahu
Copy link
Member

@sbocahu sbocahu commented Jan 23, 2024

Proposed changes

  • Respect case of headers for groups & organizations mapping of users automaticaly authenticated by proxy headers (authentication 'header' provider)

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality

Further comments

untested; however it seems to be straightforward

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2e21cd8) 66.12% compared to head (ee8ff5f) 66.11%.
Report is 1 commits behind head on master.

Files Patch % Lines
...i-platform/opencti-graphql/src/config/providers.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5664      +/-   ##
==========================================
- Coverage   66.12%   66.11%   -0.01%     
==========================================
  Files         512      512              
  Lines       60429    60429              
  Branches     4407     4406       -1     
==========================================
- Hits        39956    39952       -4     
- Misses      20473    20477       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richard-julien
Copy link
Member

Thanks be already fix by c8125ab

@SamuelHassine SamuelHassine deleted the authent-header-provider-case-fix branch February 10, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants