Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure node-saml wantAuthnResponseSigned parameter #5668

Merged

Conversation

sbocahu
Copy link
Member

@sbocahu sbocahu commented Jan 24, 2024

Proposed changes

  • Allow to configure node-saml's parameter wantAuthnResponseSigned when using env variables

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality

Further comments

References:

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c0a5db7) 66.11% compared to head (acb3a9a) 66.12%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5668   +/-   ##
=======================================
  Coverage   66.11%   66.12%           
=======================================
  Files         512      512           
  Lines       60429    60430    +1     
  Branches     4407     4408    +1     
=======================================
+ Hits        39954    39957    +3     
+ Misses      20475    20473    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelHassine SamuelHassine merged commit e32f24e into master Jan 24, 2024
5 checks passed
@SamuelHassine SamuelHassine deleted the saml_provider_add_option_wantAuthnResponseSigned branch January 24, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants