[backend] Improve config restrictions / visibility for batch rel loading #6473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6473 +/- ##
==========================================
- Coverage 67.65% 67.65% -0.01%
==========================================
Files 532 532
Lines 65001 65017 +16
Branches 5434 5437 +3
==========================================
+ Hits 43979 43988 +9
- Misses 21022 21029 +7 ☔ View full report in Codecov by Sentry. |
labo-flg
reviewed
Mar 27, 2024
| return resolve; | ||
| } | ||
| // If access is not possible, return a restricted entity | ||
| return { id: resolve.internal_id, name: 'Restricted', entity_type: resolve.entity_type }; |
There was a problem hiding this comment.
Would it be possible for a given entity_type to NOT have a name attribute, leading to an impossible object schema-wise ? an opinion for instance.
There was a problem hiding this comment.
I have the same issue in my PR #6323
There was a problem hiding this comment.
As discussed, if you're confident it concerns only entities with names, let's go for it as it would not be disruptive for the frontend side.
labo-flg
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different improvements out of the milestone.