Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] replace primary color by marking color (#6542) #6554

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

frapuks
Copy link
Member

@frapuks frapuks commented Apr 3, 2024

Proposed changes

  • replace MUI icon by custom component ItemIcon
  • use marking color

image

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

  • Need to define a way to improve visibility of TLP icon with white color in light mode (FFFFFF icon on FFFFFF background)

image

@frapuks frapuks added the filigran team use to identify PR from the Filigran team label Apr 3, 2024
@frapuks frapuks self-assigned this Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.76%. Comparing base (0067e4d) to head (376c815).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6554   +/-   ##
=======================================
  Coverage   67.76%   67.76%           
=======================================
  Files         532      532           
  Lines       65065    65065           
  Branches     5462     5465    +3     
=======================================
  Hits        44093    44093           
  Misses      20972    20972           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamuelHassine SamuelHassine merged commit c1d49eb into master Apr 3, 2024
8 checks passed
@SamuelHassine SamuelHassine deleted the issue/6542 branch April 3, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing marking colors in group edition form
2 participants