Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend] Refacto of data tables dimensions computation (#8808) #8930

Merged
merged 6 commits into from
Dec 3, 2024
Merged

[frontend] Refacto of data tables dimensions computation (#8808) #8930

merged 6 commits into from
Dec 3, 2024

Conversation

lndrtrbn
Copy link
Member

@lndrtrbn lndrtrbn commented Nov 6, 2024 •
edited
Loading

Proposed changes

  • Refactor how dimensions of DataTables are computed.
    • For width: use CSS with flexboxes instead of JS
    • For height: keep JS
  • Remove some code not useful anymore

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Nov 6, 2024
@lndrtrbn lndrtrbn self-assigned this Nov 12, 2024
@lndrtrbn lndrtrbn changed the title Issue/8808 [frontend] Refacto of data tables dimensions computation (#8808) Nov 12, 2024
@lndrtrbn lndrtrbn marked this pull request as ready for review November 13, 2024 11:34
@Archidoit
Copy link
Member

No tooltip showing for long values in columns anymore :
image

@Archidoit
Copy link
Member

The space before the 'Name' column title is now very tiny in Group Edition form > Members tab.

In your PR :
image

Before :
image

@Archidoit
Copy link
Member

Functionnally ok 👍 Really good improvements
Re-render is better after sorting
Columns sorting with different screen sizes is working well

@Archidoit
Copy link
Member

Attack patterns names are displayed as '...' whereas a name is displayed in the tooltip
image

@lndrtrbn
Copy link
Member Author

Found an issue while resizing columns, header and lines are not resized the same, need to investigate

@lndrtrbn lndrtrbn linked an issue Nov 18, 2024 that may be closed by this pull request
Bulk actions invisible in the tool bar for some screens resolution #8808
Closed
@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.10%. Comparing base (0640390) to head (add3a7d).
Report is 1 commits behind head on release/6.5.0.

Additional details and impacted files 
@@              Coverage Diff               @@
##           release/6.5.0    #8930   +/-   ##
==============================================
  Coverage          65.09%   65.10%           
==============================================
  Files                626      626           
  Lines              59738    59738           
  Branches            6644     6645    +1     
==============================================
+ Hits               38888    38893    +5     
+ Misses             20850    20845    -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lndrtrbn lndrtrbn force-pushed the issue/8808 branch 2 times, most recently from d43d2aa to 7c2da7b Compare November 19, 2024 09:13
@lndrtrbn lndrtrbn marked this pull request as draft November 27, 2024 08:40
@lndrtrbn lndrtrbn force-pushed the issue/8808 branch 2 times, most recently from 8e56b7c to 2558871 Compare November 27, 2024 08:53
@lndrtrbn lndrtrbn changed the base branch from master to release/6.5.0 November 27, 2024 09:02
@lndrtrbn lndrtrbn marked this pull request as ready for review November 28, 2024 14:30
@CelineSebe
Copy link
Member

Tested locally, everything is working fine now with the fixes

@Archidoit
Copy link
Member

Archidoit commented Dec 3, 2024 •
edited
Loading

When I move the window into an other, tinnier screen, and reset the table, nothing happens and the bottom scrollbar is still present :
image

@Archidoit
Copy link
Member

In Data>Entities, with a screen size of a laptop, if the left menu panel is opened, we don't see full the markings chips :
image

@lndrtrbn lndrtrbn merged commit 0c3677c into release/6.5.0 Dec 3, 2024
5 checks passed
@lndrtrbn lndrtrbn deleted the issue/8808 branch December 3, 2024 13:58
@SouadHadjiat SouadHadjiat mentioned this pull request Dec 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Archidoit Archidoit Archidoit approved these changes

@CelineSebe CelineSebe CelineSebe approved these changes

Assignees

@lndrtrbn lndrtrbn

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bulk actions invisible in the tool bar for some screens resolution
3 participants
@lndrtrbn @Archidoit @CelineSebe