Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] fetch creators on observable creation (#8686) #9056

Merged
merged 8 commits into from
Nov 26, 2024
Merged

Conversation

delemaf
Copy link
Member

@delemaf delemaf commented Nov 18, 2024

Proposed changes

  • On observable creation, creators are now fetched after creation
  • Added some typings to StixCyberObservableCreation and removed useless undefined props

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

I've added objectOrganization to me object in useAuth if it may be use anywhere else

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Nov 18, 2024
@delemaf delemaf self-assigned this Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.93%. Comparing base (d3a85de) to head (44a7719).
Report is 22 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9056      +/-   ##
==========================================
+ Coverage   64.68%   65.93%   +1.24%     
==========================================
  Files         620      624       +4     
  Lines       59208    59976     +768     
  Branches     6520     7617    +1097     
==========================================
+ Hits        38301    39546    +1245     
+ Misses      20907    20430     -477     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delemaf delemaf marked this pull request as ready for review November 19, 2024 10:23
@delemaf delemaf changed the title [frontend] fetch creators on observable creation & add default author [frontend] fetch creators on observable creation & add default author #8686 Nov 19, 2024
@delemaf delemaf changed the title [frontend] fetch creators on observable creation & add default author #8686 [frontend] fetch creators on observable creation & add default author (#8686) Nov 19, 2024
@delemaf delemaf changed the title [frontend] fetch creators on observable creation & add default author (#8686) [frontend] fetch creators on observable creation (#8686) Nov 25, 2024
Copy link
Member

@SouadHadjiat SouadHadjiat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally ✅

@delemaf delemaf merged commit 5d3920d into master Nov 26, 2024
6 checks passed
@SamuelHassine SamuelHassine deleted the issue/8686 branch January 5, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Author not assigned as Creator if object created outside Report
2 participants