Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Avoid URI filters repercussion in relationship creation forms (#8511) #9066

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Archidoit
Copy link
Member

Proposed changes

Avoid filters repercussion in several screens:

  • Filters in relationship creation form should not be based on the URI
  • Local storage keys should be independant in the different screens of the Knowledge tab of an entity

Related issues

#8511

@Archidoit Archidoit added the filigran team use to identify PR from the Filigran team label Nov 18, 2024
@Archidoit Archidoit self-assigned this Nov 18, 2024
@Archidoit Archidoit changed the title [frontend] Avoid URI filters repercussion in relationship creation form (#8511) [frontend] Avoid URI filters repercussion in relationship creation forms (#8511) Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.25%. Comparing base (3b945eb) to head (23d96fd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9066      +/-   ##
==========================================
+ Coverage   65.23%   65.25%   +0.01%     
==========================================
  Files         630      630              
  Lines       60380    60427      +47     
  Branches     6773     6786      +13     
==========================================
+ Hits        39388    39429      +41     
- Misses      20992    20998       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Archidoit Archidoit marked this pull request as draft November 19, 2024 08:25
@Archidoit Archidoit marked this pull request as ready for review December 11, 2024 10:04
@Archidoit Archidoit marked this pull request as draft December 16, 2024 07:32
@richard-julien richard-julien force-pushed the master branch 5 times, most recently from b414944 to c7f4cb7 Compare January 13, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Knowledge filters are repercuiting in relationship creation entities list
1 participant