[backend] Fix distribution widget by creator error (#9117) #9118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9118 +/- ##
=======================================
Coverage 64.97% 64.97%
=======================================
Files 623 623
Lines 59496 59496
Branches 6577 6579 +2
=======================================
Hits 38656 38656
Misses 20840 20840 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
marieflorescontact
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Check the issue for repro steps
Checklist
Further comments
I think we might need to fix this issue differently at some point. Right now it will display the same data as for admin users, but it's missing all the data created by system users which I think we should display.
Sorry I didn't write any integration test for this, it would take a lot of time since audit logs resolver test doesn't even exist, and I would need to fill the database with data created by internal users (currently everything is created with admin)