-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend/frontend] Add assignee through automation playbook (#7728) #9132
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9132 +/- ##
==========================================
+ Coverage 65.23% 65.26% +0.02%
==========================================
Files 624 624
Lines 59616 59631 +15
Branches 6639 6653 +14
==========================================
+ Hits 38892 38916 +24
+ Misses 20724 20715 -9 ☔ View full report in Codecov by Sentry. |
Why can't we add assignees, and just replace ? The first thing I tried to do to test the feature is "add" not "replace", since I want to add an assignee. @SarahBocognano @nino-filigran @romain-filigran @SarahBocognano : It's because we only do a fieldPatchAttribute on assignees. It's the same logic with mass operations. |
opencti-platform/opencti-front/src/private/components/data/playbooks/PlaybookAddComponents.jsx
Outdated
Show resolved
Hide resolved
opencti-platform/opencti-graphql/src/modules/playbook/playbook-components.ts
Outdated
Show resolved
Hide resolved
8c95a45
to
da3d9b8
Compare
opencti-platform/opencti-graphql/src/modules/playbook/playbook-components.ts
Outdated
Show resolved
Hide resolved
c1ce5f6
to
ae88b14
Compare
Add assignee & participants work well. There is just an issue with the message when we select remove : I can see two messages, as soon as I select remove. I wonder if we couldn't use the same message for labels, markings, assignees, and participants @SarahBocognano @nino-filigran I also think the current message shouldn't be the same for replace and remove operations : replace will in fact add to the existing values, and remove won't work at all for values that are already present in db. |
Proposed changes
Related issues
To test
FIY: You need to enable your worker to be able to ingest AND to be on the related branch in client-python as it's a multi repository feature