Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend/frontend] Add assignee through automation playbook (#7728) #9132

Merged
merged 9 commits into from
Dec 10, 2024

Conversation

SarahBocognano
Copy link
Member

Proposed changes

  • Add ObjectAssigneeFields in Manipulate Knowledge playbook form
  • Add Assignee Input into playbook components for mapping attribute

Related issues

To test

  • Add a new playbook
  • Choose to "Listen Knowledge Event" block
  • Choose an event to listen (create/update or both)
  • Proceed to filter to a Case (Incident/RFT/RFI/Task)
  • Add "Manipulate Knowledge" block
  • Select Replace => Assignee => Value of your choice
  • Add "Send for Ingestion" block
  • Go to a Case and and update/create
  • After a moment you should be able to see the new Assignee in this case

FIY: You need to enable your worker to be able to ingest AND to be on the related branch in client-python as it's a multi repository feature

@SarahBocognano SarahBocognano added filigran team use to identify PR from the Filigran team multi-repository For contribution that requires PR in several repository labels Nov 25, 2024
@SarahBocognano SarahBocognano self-assigned this Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.26%. Comparing base (7f5c793) to head (4bf7254).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9132      +/-   ##
==========================================
+ Coverage   65.23%   65.26%   +0.02%     
==========================================
  Files         624      624              
  Lines       59616    59631      +15     
  Branches     6639     6653      +14     
==========================================
+ Hits        38892    38916      +24     
+ Misses      20724    20715       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SouadHadjiat SouadHadjiat self-requested a review November 25, 2024 14:05
@SouadHadjiat
Copy link
Member

SouadHadjiat commented Nov 25, 2024

Why can't we add assignees, and just replace ? The first thing I tried to do to test the feature is "add" not "replace", since I want to add an assignee. @SarahBocognano @nino-filigran @romain-filigran
image

@SarahBocognano : It's because we only do a fieldPatchAttribute on assignees. It's the same logic with mass operations.

@SouadHadjiat
Copy link
Member

SouadHadjiat commented Nov 25, 2024

When I test replace assignee, it's adds the assignees, it doens't replace them. I tried with a report I created with "admin" assignee, with a playbook replace with two assignees, and I end up with 3 assignees. => It's the same logic with labels, it doesn't really replace, but there is message explaining it, maybe we should have a similar message for assignees too ? otherwise it's just confusing
image
image

@SouadHadjiat
Copy link
Member

SouadHadjiat commented Dec 10, 2024

Add assignee & participants work well.

There is just an issue with the message when we select remove : I can see two messages, as soon as I select remove. I wonder if we couldn't use the same message for labels, markings, assignees, and participants @SarahBocognano @nino-filigran
image

I also think the current message shouldn't be the same for replace and remove operations : replace will in fact add to the existing values, and remove won't work at all for values that are already present in db.

@SarahBocognano SarahBocognano merged commit bde36b7 into master Dec 10, 2024
6 checks passed
@SarahBocognano SarahBocognano deleted the issue/7728 branch December 10, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team multi-repository For contribution that requires PR in several repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants