Improve social previews of EB URLs #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens mostly when someone pastes a link to a social medium which redirects immediately to OpenConext and e.g. shows a WAYF. The social preview of that link is then the logo of the first IdP in the wayf. This improves on that by ensuring that the logo used is the OpenConext instance's own logo. There are more fields available in the OpenGraph specification but we do not have readily available content for those fields. The fields we add now we can fill with information we already have in the template so are a quick way to improve the social previews over the previous situation.
KarsanHAM
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens mostly when someone pastes a link to a social medium which redirects immediately to OpenConext and e.g. shows a WAYF. The social preview of that link is then the logo of the first IdP in the wayf. This improves on that by ensuring that the logo used is the OpenConext instance's own logo. This is a less "random" experience.
There are more fields available in the OpenGraph specification but we do not have readily available content for those fields. The fields we add now we can fill with information we already have in the template so are a quick way to improve the social previews over the previous situation.