Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/docker configs #188

Merged
merged 11 commits into from
Apr 3, 2024
Merged

Feature/docker configs #188

merged 11 commits into from
Apr 3, 2024

Conversation

danakim
Copy link
Contributor

@danakim danakim commented Nov 14, 2023

Hi @quartje! This is the initial version of the PR. Like we discussed, you will need to add the configs to the Docker image. The paths are:

For Apache2: add it in /etc/apache2/sites-enabled/
For Shibboleth: overwrite the file /etc/shibboleth/shibboleth2.xml

@danakim danakim requested a review from quartje November 14, 2023 13:19
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.53%. Comparing base (31a2718) to head (b6e1e48).

❗ Current head b6e1e48 differs from pull request most recent head c61bf58. Consider uploading reports for the commit c61bf58 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #188      +/-   ##
============================================
+ Coverage     89.43%   89.53%   +0.10%     
+ Complexity     1024     1021       -3     
============================================
  Files           111      110       -1     
  Lines          3444     3422      -22     
  Branches        276      274       -2     
============================================
- Hits           3080     3064      -16     
+ Misses          251      247       -4     
+ Partials        113      111       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@quartje quartje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I click the actions tab, it mentions an error on line 109 of the deploy.yml workflow.

@danakim
Copy link
Contributor Author

danakim commented Nov 16, 2023

@quartje - oops, yaml format error. Fixed it.

@quartje quartje force-pushed the feature/docker_configs branch from b6e1e48 to c61bf58 Compare April 3, 2024 13:17
@quartje quartje force-pushed the feature/docker_configs branch from c61bf58 to e4e7715 Compare April 3, 2024 13:21
@quartje quartje merged commit cacdf7a into master Apr 3, 2024
@quartje quartje deleted the feature/docker_configs branch April 3, 2024 13:22
@quartje quartje restored the feature/docker_configs branch May 21, 2024 18:45
@quartje quartje deleted the feature/docker_configs branch May 24, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants