Skip to content

Commit

Permalink
Refactor all ParamConverters to ValueResolvers
Browse files Browse the repository at this point in the history
Refactor all ParamConverters to ValueResolvers and removed the
deprecated SymfonyExtraBundle because that's now not used anymore.
  • Loading branch information
pablothedude committed Nov 12, 2024
1 parent b9ff9de commit 4415820
Show file tree
Hide file tree
Showing 12 changed files with 557 additions and 649 deletions.
46 changes: 23 additions & 23 deletions ci/qa/phpstan-baseline.neon
Original file line number Diff line number Diff line change
Expand Up @@ -3115,45 +3115,35 @@ parameters:
count: 1
path: ../../src/Surfnet/StepupMiddleware/ApiBundle/Identity/Value/RegistrationAuthorityCredentials.php

-
message: "#^Argument of an invalid type mixed supplied for foreach, only iterables are supported\\.$#"
count: 1
path: ../../src/Surfnet/StepupMiddleware/ApiBundle/Request/CommandParamConverter.php

-
message: "#^Cannot access offset 'command' on mixed\\.$#"
count: 3
path: ../../src/Surfnet/StepupMiddleware/ApiBundle/Request/CommandParamConverter.php
path: ../../src/Surfnet/StepupMiddleware/ApiBundle/Request/CommandValueResolver.php

-
message: "#^Cannot access offset 'name' on mixed\\.$#"
count: 1
path: ../../src/Surfnet/StepupMiddleware/ApiBundle/Request/CommandParamConverter.php
path: ../../src/Surfnet/StepupMiddleware/ApiBundle/Request/CommandValueResolver.php

-
message: "#^Cannot access offset 'payload' on mixed\\.$#"
count: 1
path: ../../src/Surfnet/StepupMiddleware/ApiBundle/Request/CommandParamConverter.php
path: ../../src/Surfnet/StepupMiddleware/ApiBundle/Request/CommandValueResolver.php

-
message: "#^Cannot access offset 'uuid' on mixed\\.$#"
count: 1
path: ../../src/Surfnet/StepupMiddleware/ApiBundle/Request/CommandParamConverter.php
path: ../../src/Surfnet/StepupMiddleware/ApiBundle/Request/CommandValueResolver.php

-
message: "#^Cannot cast mixed to string\\.$#"
count: 2
path: ../../src/Surfnet/StepupMiddleware/ApiBundle/Request/CommandParamConverter.php

-
message: "#^Property Surfnet\\\\StepupMiddleware\\\\CommandHandlingBundle\\\\Command\\\\AbstractCommand\\:\\:\\$UUID \\(string\\) does not accept mixed\\.$#"
count: 1
path: ../../src/Surfnet/StepupMiddleware/ApiBundle/Request/CommandParamConverter.php
path: ../../src/Surfnet/StepupMiddleware/ApiBundle/Request/CommandValueResolver.php

-
message: "#^Cannot access property \\$meta on mixed\\.$#"
count: 1
path: ../../src/Surfnet/StepupMiddleware/ApiBundle/Request/MetadataParamConverter.php
path: ../../src/Surfnet/StepupMiddleware/ApiBundle/Request/MetadataValueResolver.php

-
message: "#^Method Surfnet\\\\StepupMiddleware\\\\ApiBundle\\\\Response\\\\JsonAuthorizationResponse\\:\\:__construct\\(\\) has parameter \\$errors with no value type specified in iterable type array\\.$#"
Expand Down Expand Up @@ -3281,24 +3271,34 @@ parameters:
path: ../../src/Surfnet/StepupMiddleware/ApiBundle/Tests/Identity/Projector/AuditLogProjectorTest.php

-
message: "#^Method Surfnet\\\\StepupMiddleware\\\\ApiBundle\\\\Tests\\\\Request\\\\CommandParamConverterTest\\:\\:convertibleCommandNames\\(\\) return type has no value type specified in iterable type array\\.$#"
message: "#^Cannot access offset 0 on iterable\\<Surfnet\\\\StepupMiddleware\\\\CommandHandlingBundle\\\\Command\\\\AbstractCommand\\>\\.$#"
count: 4
path: ../../src/Surfnet/StepupMiddleware/ApiBundle/Tests/Request/CommandValueResolverTest.php

-
message: "#^Method Surfnet\\\\StepupMiddleware\\\\ApiBundle\\\\Tests\\\\Request\\\\CommandValueResolverTest\\:\\:convertibleCommandNames\\(\\) return type has no value type specified in iterable type array\\.$#"
count: 1
path: ../../src/Surfnet/StepupMiddleware/ApiBundle/Tests/Request/CommandParamConverterTest.php
path: ../../src/Surfnet/StepupMiddleware/ApiBundle/Tests/Request/CommandValueResolverTest.php

-
message: "#^Method Surfnet\\\\StepupMiddleware\\\\ApiBundle\\\\Tests\\\\Request\\\\CommandParamConverterTest\\:\\:invalidCommandJsonStructures\\(\\) return type has no value type specified in iterable type array\\.$#"
message: "#^Method Surfnet\\\\StepupMiddleware\\\\ApiBundle\\\\Tests\\\\Request\\\\CommandValueResolverTest\\:\\:invalidCommandJsonStructures\\(\\) return type has no value type specified in iterable type array\\.$#"
count: 1
path: ../../src/Surfnet/StepupMiddleware/ApiBundle/Tests/Request/CommandParamConverterTest.php
path: ../../src/Surfnet/StepupMiddleware/ApiBundle/Tests/Request/CommandValueResolverTest.php

-
message: "#^Cannot call method equals\\(\\) on mixed\\.$#"
message: "#^Parameter \\#1 \\$expected of method PHPUnit\\\\Framework\\\\Assert\\:\\:assertInstanceOf\\(\\) expects class\\-string\\<object\\>, string given\\.$#"
count: 1
path: ../../src/Surfnet/StepupMiddleware/ApiBundle/Tests/Request/CommandValueResolverTest.php

-
message: "#^Cannot access offset 0 on iterable\\<Surfnet\\\\Stepup\\\\Identity\\\\Value\\\\Institution\\>\\.$#"
count: 1
path: ../../src/Surfnet/StepupMiddleware/ApiBundle/Tests/Request/InstitutionParamConverterTest.php
path: ../../src/Surfnet/StepupMiddleware/ApiBundle/Tests/Request/InstitutionValueResolverTest.php

-
message: "#^Property Symfony\\\\Component\\\\HttpFoundation\\\\Request\\:\\:\\$query \\(Symfony\\\\Component\\\\HttpFoundation\\\\InputBag\\<string\\>\\) does not accept Mockery\\\\MockInterface&Symfony\\\\Component\\\\HttpFoundation\\\\ParameterBag\\.$#"
count: 2
path: ../../src/Surfnet/StepupMiddleware/ApiBundle/Tests/Request/InstitutionParamConverterTest.php
path: ../../src/Surfnet/StepupMiddleware/ApiBundle/Tests/Request/InstitutionValueResolverTest.php

-
message: "#^Property Surfnet\\\\StepupMiddleware\\\\CommandHandlingBundle\\\\Configuration\\\\Command\\\\ReconfigureInstitutionConfigurationOptionsCommand\\:\\:\\$allowedSecondFactors type has no value type specified in iterable type array\\.$#"
Expand Down
1 change: 1 addition & 0 deletions ci/qa/phpunit.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
</coverage>
<php>
<ini name="error_reporting" value="-1"/>
<ini name="memory_limit" value="256M"/>
<server name="APP_ENV" value="test" force="true"/>
<server name="SHELL_VERBOSITY" value="-1"/>
<server name="KERNEL_CLASS" value="\Surfnet\StepupMiddleware\Kernel"/>
Expand Down
1 change: 0 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
"pagerfanta/doctrine-orm-adapter": "*",
"pagerfanta/pagerfanta": "^4.3",
"ramsey/uuid": "^4.7",
"sensio/framework-extra-bundle": "*",
"surfnet/stepup-bundle": "^6.0",
"symfony/asset": "6.4.*",
"symfony/expression-language": "6.4.*",
Expand Down
Loading

0 comments on commit 4415820

Please sign in to comment.