Make mail expiration date match selfservice #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKodde
force-pushed
the
feature/rejuvination
branch
from
24ad15e to
8651776
Compare
Selfservice renders the date without ->endOfDay(). Adding the endOfDay makes the date wrap to the next day when the timezone modifier is applied. More intricate timezone aware handling of this date is thinkable, but this change at least brings both interfaces to use the same algorithm so the output will be the same.
MKodde
force-pushed
the
bugfix/mail-expiration-date-match-selfservice
branch
from
ef08494 to
b53c856
Compare
MKodde
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expiration dates displayed in selfservice web UI and the corresponding email you receive are not the same:
This PR changes that by making the algoritms the same (without endOfDay()) so they will be consistent. Further improvement of timezone handling is thinkable but in any case the algoritms should be the same.