Skip to content

Commit

Permalink
Updating github actions
Browse files Browse the repository at this point in the history
Seeing if this fixes the EACCESS issues with the sonarqube step...
  • Loading branch information
thirtytwobits committed May 31, 2024
1 parent d1a3b05 commit 3aecea7
Show file tree
Hide file tree
Showing 5 changed files with 34 additions and 24 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ jobs:
runs-on: ubuntu-latest
container: ghcr.io/opencyphal/toxic:tx22.4.2
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: true
- uses: actions/setup-python@v4
- uses: actions/setup-python@v5
with:
python-version: '3.10'
- name: version-check
Expand Down
35 changes: 17 additions & 18 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
container: ghcr.io/opencyphal/toxic:tx22.4.2
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: true
- name: lint
Expand All @@ -27,37 +27,36 @@ jobs:
- name: package
run: tox -e package
- name: upload-coverage-reports
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: coverage-reports
path: .tox/report/tmp/*
- name: upload-xunit-results
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: xunit-results
path: .tox/py310-test/tmp/xunit-result.xml
- name: upload-package
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: pypi-package
path: .tox/package/dist/*

sonar:
runs-on: ubuntu-latest
needs: test
container: sonarsource/sonar-scanner-cli
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
# Disabling shallow clone is recommended for improving relevancy of reporting
fetch-depth: 0
- name: download-converage-reports
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: coverage-reports
path: .tox/report/tmp/
- name: download-xunit-results
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: xunit-results
path: .tox/py310-test/tmp/
Expand Down Expand Up @@ -104,11 +103,11 @@ jobs:
runs-on: ${{ matrix.python3-platform }}
needs: test
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: true
- name: setup python
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: 3.${{ matrix.python3-version }}
- name: setup tox
Expand All @@ -124,7 +123,7 @@ jobs:
container: ghcr.io/opencyphal/toxic:tx22.4.2
needs: test
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: true
- name: python3.${{ matrix.python3-version }} test
Expand All @@ -133,7 +132,7 @@ jobs:
language-verification-c:
runs-on: ubuntu-latest
needs: test
container: ghcr.io/opencyphal/toolshed:ts22.4.2
container: ghcr.io/opencyphal/toolshed:ts22.4.8
strategy:
matrix:
build_type: [Debug, Release, MinSizeRel]
Expand All @@ -147,7 +146,7 @@ jobs:
- build_type: Release
flag: --disable-asserts
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: true
- name: verify
Expand All @@ -163,7 +162,7 @@ jobs:
language-verification-cpp-14:
runs-on: ubuntu-latest
needs: test
container: ghcr.io/opencyphal/toolshed:ts22.4.1
container: ghcr.io/opencyphal/toolshed:ts22.4.8
strategy:
matrix:
build_type: [Debug, Release, MinSizeRel]
Expand All @@ -178,7 +177,7 @@ jobs:
flag: --disable-asserts

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: true
- name: verify
Expand All @@ -195,7 +194,7 @@ jobs:
language-verification-cpp-17:
runs-on: ubuntu-latest
needs: test
container: ghcr.io/opencyphal/toolshed:ts22.4.1
container: ghcr.io/opencyphal/toolshed:ts22.4.8
strategy:
matrix:
build_type: [Debug, Release, MinSizeRel]
Expand All @@ -210,7 +209,7 @@ jobs:
flag: --disable-asserts

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: true
- name: verify
Expand All @@ -229,7 +228,7 @@ jobs:
needs: test
container: ghcr.io/opencyphal/toxic:tx22.4.2
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
submodules: true
- name: verify
Expand Down
15 changes: 13 additions & 2 deletions CONTRIBUTING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ skip the docker invocations and use ``tox run -s``.

To run the language verification build you'll need to use a different docker container::

docker pull ghcr.io/opencyphal/toolshed:ts22.4.5
docker run --rm -it -v $PWD:/workspace ghcr.io/opencyphal/toolshed:ts22.4.5
docker pull ghcr.io/opencyphal/toolshed:ts22.4.8
docker run --rm -it -v $PWD:/workspace ghcr.io/opencyphal/toolshed:ts22.4.8
cd /workspace
./.github/verify.py -l c
./.github/verify.py -l cpp
Expand All @@ -94,6 +94,17 @@ If you get a "denied" response from ghcr your ip might be getting rate-limited.
you'll have to login to get around any rate-limiting for your local site. See [the github docs](https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry)
for how to setup a docker client login.


If you get the following error::

gcc: error: unrecognized command-line option ‘-m32’

...it may mean you are trying to run one of our 32-bit platform tests using an armv8 docker image. For these builds
you might need to override the target platform and pull the x86 version of the container explicitly. For example::

docker run --rm -it --platform linux/amd64 -v $PWD:/workspace ghcr.io/opencyphal/toolshed:ts22.4.8


Files Generated by the Tests
================================================

Expand Down
2 changes: 1 addition & 1 deletion submodules/unity
Submodule unity updated 144 files
2 changes: 1 addition & 1 deletion verification/.devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "C/C++ verification environment",
"image": "ghcr.io/opencyphal/toolshed:ts22.4.5",
"image": "ghcr.io/opencyphal/toolshed:ts22.4.8",
"workspaceFolder": "/workspace",
"workspaceMount": "source=${localWorkspaceFolder}/..,target=/workspace,type=bind,consistency=delegated",
"mounts": [
Expand Down

0 comments on commit 3aecea7

Please sign in to comment.