Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FullNameAndVersion to c++ #343

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Add FullNameAndVersion to c++ #343

wants to merge 4 commits into from

Conversation

serges147
Copy link

No description provided.

@serges147 serges147 self-assigned this Aug 27, 2024
@serges147 serges147 requested review from thirtytwobits and removed request for thirtytwobits August 27, 2024 00:17
@serges147 serges147 marked this pull request as draft August 27, 2024 00:20
@thirtytwobits
Copy link
Member

Can you change tox.ini to remove types-pkg_resources and add types-setuptools? See 9b32600#diff-ef2cef9f88b4fe09ca3082140e67f5ad34fb65fb6e228f119d3812261ae51449L190 for the change on 3.0. (Somebody pulled this package out of Pypi recently)

@serges147 serges147 marked this pull request as ready for review August 28, 2024 07:36
@serges147
Copy link
Author

serges147 commented Aug 28, 2024 •
edited
Loading

Can you change tox.ini to remove types-pkg_resources and add types-setuptools? ...

@thirtytwobits I did, now it fails on doctest
I've created separate PR in attempt to fix main branch CI (without my c++ related changed of this pr): #344

@serges147 serges147 marked this pull request as draft August 28, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thirtytwobits thirtytwobits Awaiting requested review from thirtytwobits

@pavel-kirienko pavel-kirienko Awaiting requested review from pavel-kirienko

At least 1 approving review is required to merge this pull request.

Assignees

@serges147 serges147

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serges147 @thirtytwobits