…cand interface

in init function

the old implimentation to a new one

added another error check for socketcand
and CAN FD at same time

to file as well

_InterfaceParameters instead of separately in the
FD and classic subclasses

This reverts commit d9f8267.

library functionality. It runs on Python-CAN
like the interfaces in the PythonCANMedia class,
but because it has extra variables (host and port),
it is not very clean to just add socketcand to
PythonCANMedia.

This fixes the unnecessary pieces left from the pythonCANMedia
class, such as the FD vs Classic dataclasses, Can Bus Options,
and the constructor class. It also updates the way
parameters are inputed to be all in the iface_name
param like 'socketcand:can:host:port'

Added unit test and changed spec string to be parsed in _transport_factory

fixed formatting issues that did not pass Black guidelines

Removed unecessary params S

Updated version of the socketcandMedia class. This fixes the unnecessary pieces left from the pythonCANMedia class, such as the FD vs Classic dataclasses, Can Bus Options, and the constructor class. It also updates the way parameters are inputed to be all in the iface_name param like 'socketcand:can:host:port'

SocketcandMedia Media class added for socketcand library functionality. It runs on Python-CAN like the interfaces in the PythonCANMedia class, but because it has extra variables (host and port), it is not very clean to just add socketcand to PythonCANMedia.

builds and installs socketcand, sets up vcan, and starts socketcand

…for output

Test environment now properly builds and breaks down socketcand
Tests use rx_a and rx_b for proper communication

Also modified docs of SocketcandMedia, and updated socketcandMedia
test to only start the daemon instead of building socketcand, setting
up a vcan, and then running the daemon, now socketcand is installed
in workflow and we use an existing vcan set up previously.
I also added some error handling for running the socketcand
daemon and made sure to kill the process correctly

Co-authored-by: Pavel Kirienko <[email protected]>

In the previous commit it was mostly doc updates, but one changed the
socketcandmedia interface_name return. I forgot to update the unit test
assertions to match this, so in the CI testing it resulted in a
never ending loop. The issue stemmed from the way Popen gets stderr
and stdout with the communicate method, but only after the yield
statement. It does not respond to the kill() and instead runs forever,
so I replaced it with just a kill. Although you lose a little bit of
info, the socketcand instance gets checked before the unit test
is done in the fixture, and from there the daemon is very robust and
will not stop unless you force kill it or terminate it. So I think this
is the best solution, you still get output from errors within the unit
test as well.

Also made small tweaks based on code change requests,
removed some redundacy, slightly changed docs.