[PATCH v3] improve validation testing with 1 or 2 CPUs #2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
JannePeltonen
commented
Jan 19, 2024
JannePeltonen
commented
- Let validation tests pass in 1-CPU systems by relaxing tolerances in 2-thread globl time sync test.
- Enable sched order wait test in systems with less than 1 worker.
odpbuild
changed the title
MatiasElo
approved these changes
Jan 19, 2024
JannePeltonen
force-pushed
the
val-one-cpu
branch
from
85eb6fb to
0f9d941
Compare
odpbuild
changed the title
Run the 2-thread odp_schedule_order_wait() test regardless of the number of worker CPUs. The test anyway uses just single worker thread and the main (control) thread. This enables the test in systems with just one or two CPUs. Signed-off-by: Janne Peltonen <[email protected]> Reviewed-by: Matias Elo <[email protected]>
When running the 2-thread time_test_global_sync_control() test in a system with only one CPU core, the control and worker threads run in the same core, which shows up as time differences of the order of the thread scheduling interval of the underlying OS. Increase the allowed error when the threads run in the same CPU core. Signed-off-by: Janne Peltonen <[email protected]> Reviewed-by: Matias Elo <[email protected]>
odpbuild
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.