Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH v2] linux-gen: pool: optimize freeing events to a single pool #2172

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

MatiasElo
Copy link
Collaborator

No description provided.

@odpbuild odpbuild changed the title linux-gen: pool: optimize freeing events to a single pool [PATCH v1] linux-gen: pool: optimize freeing events to a single pool Jan 10, 2025
Copy link
Collaborator

@TuomasTaipale TuomasTaipale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK. Maybe something could be added to the commit messages of a21d6bf and 15a6093 about what exactly makes them now optimized.

Depending on packet reference API implementation a larger test packet pool
may be required, as using packet copies is a valid implementation.

Signed-off-by: Matias Elo <[email protected]>
Reviewed-by: Tuomas Taipale <[email protected]>
Add implementation internal function _odp_event_free_sp() for freeing all
events to the same pool. Use the new function where appropriate to increase
performance.

Signed-off-by: Matias Elo <[email protected]>
Reviewed-by: Tuomas Taipale <[email protected]>
Add optimized implementation for odp_packet_free_sp() function. The updated
implementation utilizes internal _odp_event_free_sp() function which
assumes all packets are from the same pool.

Signed-off-by: Matias Elo <[email protected]>
Reviewed-by: Tuomas Taipale <[email protected]>
Optimize odp_event_free_sp() implementation for buffer, packet, and timeout
events. The updated implementation utilizes event type specific same pool
free functions.

Signed-off-by: Matias Elo <[email protected]>
Reviewed-by: Tuomas Taipale <[email protected]>
@odpbuild odpbuild changed the title [PATCH v1] linux-gen: pool: optimize freeing events to a single pool [PATCH v2] linux-gen: pool: optimize freeing events to a single pool Jan 17, 2025
@MatiasElo
Copy link
Collaborator Author

V2:

  • Improved commit messages

@MatiasElo MatiasElo enabled auto-merge (rebase) January 17, 2025 12:46
@MatiasElo MatiasElo merged commit 9cc4c60 into OpenDataPlane:master Jan 17, 2025
160 checks passed
@MatiasElo MatiasElo deleted the dev/free-sp branch January 17, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants