[PATCH v3] remove unused longindex #2173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatiasElo
approved these changes
Jan 17, 2025
|
About squashing, these are standalone and mostly targeting implementation-independent programs, so might as well be separate commits. |
|
I would prefer squashing since they are all the same change and I do not see much (any?) benefit in not squashing. |
TuomasTaipale
force-pushed
the
dev/longopts
branch
from
2a571e4 to
a4918ab
Compare
odpbuild
changed the title
When parsing command line arguments with `getopt_long()`, longindex output pointer can be `NULL` if it is not needed. Signed-off-by: Tuomas Taipale <[email protected]> Reviewed-by: Matias Elo <[email protected]>
When parsing command line arguments with `getopt_long()`, longindex output pointer can be `NULL` if it is not needed. Signed-off-by: Tuomas Taipale <[email protected]> Reviewed-by: Matias Elo <[email protected]>
When parsing command line arguments with `getopt_long()`, longindex output pointer can be `NULL` if it is not needed. Signed-off-by: Tuomas Taipale <[email protected]> Reviewed-by: Matias Elo <[email protected]>
MatiasElo
force-pushed
the
dev/longopts
branch
from
a4918ab to
4baecf8
Compare
odpbuild
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing command line arguments with
getopt_long(), longindex output pointer can beNULLif it is not needed.v2: