Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure cost and its subclasses #1999

Merged

Conversation

LillyG901
Copy link
Contributor

@LillyG901 LillyG901 commented Dec 14, 2024

Summary of the discussion

See #1914

Type of change (CHANGELOG.md)

Update

  • make cost (and all its subclasses) subclass of process attribute

Workflow checklist

Automation

Closes #1914

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@github-actions github-actions bot added the oeo-social changes the oeo-social module label Dec 14, 2024
@LillyG901 LillyG901 marked this pull request as ready for review January 13, 2025 10:52
@stap-m stap-m requested review from stap-m and madbkr January 14, 2025 12:38
src/ontology/edits/oeo-social.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-social.omn Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@stap-m
Copy link
Contributor

stap-m commented Jan 14, 2025

There is one axiom of social cost which can be deleted without discussion, which is the one to the obsolete class 'economic value'. Seems like we missed to remove it once we made the relation obsolete...

@madbkr
Copy link
Contributor

madbkr commented Jan 15, 2025

I started the reasoner (used HermiT) and for me cost and all its subclasses are equivalent to owl:Nothing. Here is the explaination that Protegé offered:

Bildschirmfoto vom 2025-01-15 13-38-08

So we have to make more changes if we want to move cost like this.

@stap-m
Copy link
Contributor

stap-m commented Jan 15, 2025

Good catch @madbkr

@areleu
Copy link
Contributor

areleu commented Jan 15, 2025

I started the reasoner (used HermiT) and for me cost and all its subclasses are equivalent to owl:Nothing. Here is the explaination that Protegé offered:

Bildschirmfoto vom 2025-01-15 13-38-08

So we have to make more changes if we want to move cost like this.

That is a tricky one, but I can imagine this will happen to any other quantity values that are directly converted to process attributes, at least those with the has unit axiom.

@stap-m
Copy link
Contributor

stap-m commented Jan 15, 2025

We discussed in #1875 which former quantity values are actually quantities or process attributes. This PR is part of the restructuring. Both quantities and process attributes can be "measured" by quantity values, which are allowed for units. Therefore, I guess the solution is to change the axiomatisation: remove the "has unit" axioms for all process attributes and replace them with has quantity value linking to a corresponding quanity value.

@stap-m
Copy link
Contributor

stap-m commented Jan 16, 2025

And the corresponding quantity value would be monetary value.

@LillyG901
Copy link
Contributor Author

There is one axiom of social cost which can be deleted without discussion, which is the one to the obsolete class 'economic value'. Seems like we missed to remove it once we made the relation obsolete...

I found that monetary value and emission certificate price also have an axiom related to the obsolete class. Should I also remove them in this PR?
The axiom of emission certificate price is part of the axiom that defines it as an equivalent class. Can I remove this without issue?

@LillyG901
Copy link
Contributor Author

I started the reasoner (used HermiT) and for me cost and all its subclasses are equivalent to owl:Nothing. Here is the explaination that Protegé offered:

Thanks for pointing it out. It seems my reasoner does not show inconsistencies until after it's synchronized. Just starting doesn't seem to work.

@madbkr
Copy link
Contributor

madbkr commented Jan 20, 2025

I don't know if this is still a work in progress. But since you have some issues with the reasoner not working right I wanted to point out that my reasoner finds a lot of issues with the shared-axioms file now. It tells me the ontology is inconsistent with a lot of possible explanations. Everything, not just cost is now red in the file. I'll put one of the justifications here, maybe it helps.
Bildschirmfoto vom 2025-01-20 12-01-27

@stap-m
Copy link
Contributor

stap-m commented Jan 20, 2025

grafik

I removed some more obsolete axioms. The only classes below owl:Nothing are now social cost of emission and its subclass. Here the inference it hurt due to the axiom to emission rate, which we discussed to remove anyway, see #1914 (comment). I will remove them now, too.

One of the removed axioms was 'transport network component' SubClassOf 'obsolete has economic value' some cost. @LillyG901 could you open an issue to discuss a correct compensation axiom please?

@LillyG901
Copy link
Contributor Author

I added issue #2009

@LillyG901 LillyG901 merged commit 4d82e5c into dev Jan 29, 2025
3 checks passed
@LillyG901 LillyG901 deleted the feature-1914-move-cost-and-subclasses-to-process-attribute branch January 29, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-shared-axioms oeo-social changes the oeo-social module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

cost subclasses have to be rescructured according to #1875
5 participants