Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ofp_sendto should return the number of bytes sent #250

Open
gabeblack opened this issue May 15, 2020 · 1 comment
Open

ofp_sendto should return the number of bytes sent #250

gabeblack opened this issue May 15, 2020 · 1 comment

Comments

@gabeblack
Copy link

It appears that ofp_send/sendto returns 0 if the packet is sent. This diverges from the normal socket send/sendto calls in that they return the number of bytes sent. Not sure if that is intentional or not as the apis don't seem to be documented as to what they supposed to return. However, given that there is netwrap stuff, it seems like it is intended to mimic the same api.
@bogdanPricope
Copy link
Contributor

Hi,
I guess it was a UDP socket. Take a look at PR#251 ("udp: fix ofp_send/ofp_sendto return value on success").

@MatiasElo MatiasElo mentioned this issue Jun 12, 2020
Merged
bogdanPricope added a commit to bogdanPricope/ofp that referenced this issue Jun 14, 2020
@bogdanPricope
udp: fix ofp_send/ofp_sendto return value on success
bdc04d5 
On UDP side, remaining bytes to process were not updated.
This commit fixes issue OpenFastPath#250.

Signed-off-by: Bogdan Pricope <[email protected]>
Reviewed-by: Matias Elo <[email protected]>
MatiasElo pushed a commit that referenced this issue Jun 15, 2020
@bogdanPricope @MatiasElo
udp: fix ofp_send/ofp_sendto return value on success
567efd5 
On UDP side, remaining bytes to process were not updated.
This commit fixes issue #250.

Signed-off-by: Bogdan Pricope <[email protected]>
Reviewed-by: Matias Elo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gabeblack @bogdanPricope