udp: fix ofp_send/ofp_sendto return value on success #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabeblack
reviewed
May 18, 2020
|
Nope. Validation should be done against sent buffer size for UDP packets. |
|
Note: if you want to check with dpdk pktio you need to wait for my next PR. You may use socket based pktio for this test. |
|
You could mention in the commit message that this commit fixes issue #250. E.g. Fixes: url_to_issue |
MatiasElo
approved these changes
Jun 12, 2020
On UDP side, remaining bytes to process were not updated. This commit fixes issue OpenFastPath#250. Signed-off-by: Bogdan Pricope <[email protected]> Reviewed-by: Matias Elo <[email protected]>
Returned value of ofp_send() and ofp_sendto() is validated against sent buffer size for UDP. Signed-off-by: Bogdan Pricope <[email protected]> Reviewed-by: Matias Elo <[email protected]>
bogdanPricope
force-pushed
the
sendto_udp
branch
from
7760dc8 to
2740122
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On UDP side, remaining bytes to process were not updated.