Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gzip and deflate compression support in Http2Client #2738

Merged
merged 5 commits into from
Jan 27, 2025

Conversation

hicom150
Copy link
Contributor

This PR has the following changes in order to add support for gzip and deflate compression.

  • Enable Http2Client tests
  • Fix Http2Client timeoutTest:
    It seems that Java 11 HttpClient timeout stops when response headers are received. https://bugs.openjdk.org/browse/JDK-8208693
    So to fix the test I adjust the mock accordingly.
  • Override some AbstractClientTests as Http2Client does not expose reason phrase:
    Java 11 HttpClient does not expose reason phrase.
  • Add gzip and deflate compression support in Http2Client

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@hicom150
Copy link
Contributor Author

@velo Could you help pushing this PR forward?
Thank you!

@velo velo enabled auto-merge (squash) January 27, 2025 16:22
github-actions[bot]

This comment was marked as off-topic.

@velo velo merged commit 71604b5 into OpenFeign:master Jan 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants