Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Temporaly disabling ksp testing" #735

Open
wants to merge 1 commit into
base: querydsl-7.0
Choose a base branch
from

Conversation

velo
Copy link
Member

@velo velo commented Dec 14, 2024

This reverts commit 128a207.

@velo velo force-pushed the enable_ksp_example branch from 6a44538 to 867f361 Compare December 14, 2024 11:49
@velo
Copy link
Member Author

velo commented Dec 14, 2024

@IceBlizz6 made the issue a separated PR, any assistance you can give, would be appreciated

@IceBlizz6
Copy link
Contributor

I'm looking into it.
Not currently able to recreate the issue, the project built as expected and all the tests ran successfully.

@velo
Are you able to recreate this issue on your machine?

@IceBlizz6
Copy link
Contributor

Nevermind, was able to recreate it now i think.
Forgot to recreate the properties file with the new versions.

@IceBlizz6
Copy link
Contributor

IceBlizz6 commented Dec 14, 2024

Seems to be solved by updating hibernate.version
7.0.0.Beta1 -> 7.0.0.Beta3

@velo
Copy link
Member Author

velo commented Dec 15, 2024

Seems to be solved by updating hibernate.version 7.0.0.Beta1 -> 7.0.0.Beta3

Ow, that is a problem
#738

@IceBlizz6
Copy link
Contributor

I could try to take a closer look if there are other solutions, but i have some doubts of whether that is even an option.
There will always be some risks when trying to use beta versions.

may i ask why we are trying to update to the hibernate beta version?

@velo
Copy link
Member Author

velo commented Dec 16, 2024

Jpa 3.2 support... And that is forcing java 11 out, that is why I decided to start a 7 series branch

@IceBlizz6
Copy link
Contributor

It looks like the error came from just trying to add a Kotlin entity class.
So this issue may not be related to KSP at all.

Configuration()
            .setProperty(AvailableSettings.JAKARTA_JDBC_DRIVER, org.h2.Driver::class.qualifiedName!!)
            .setProperty(AvailableSettings.JAKARTA_JDBC_URL, "jdbc:h2:mem:my-database;")
            .setProperty(AvailableSettings.HBM2DDL_AUTO, "create-drop")
            .setProperty(AvailableSettings.SHOW_SQL, "true")
            .addAnnotatedClass(Person::class.java) // Fails only if this line is included
            .buildSessionFactory()
            .unwrap(EntityManagerFactory::class.java)

If this is correct then anyone with a kotlin project on hibernate would be unable to use beta1 anyway.

@velo velo force-pushed the enable_ksp_example branch from 867f361 to 2f6bd03 Compare December 23, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants