Merge pull request #1122 from OpenFn/1113-investigate-workflow-diagram

Investigating Workflow Diagram
OpenFn · Sep 19, 2023 · 1b486be · 1b486be
2 parents be377bc + 99b5103
commit 1b486be
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,6 +14,9 @@ and this project adheres to
 
 ### Fixed
 
+- Fix randomly unresponsive job panel after job deletion
+  [#1113](https://github.com/OpenFn/Lightning/issues/1113)
+
 ## [v0.9.0] - 2023-09-15
 
 ### Added

diff --git a/assets/js/workflow-diagram/components/PlusButton.tsx b/assets/js/workflow-diagram/components/PlusButton.tsx
@@ -11,12 +11,12 @@ function PlusButton() {
         xmlns="http://www.w3.org/2000/svg"
         viewBox="0 0 24 24"
         fill="currentColor"
-        class="w-4 h-4"
+        className="w-4 h-4"
       >
         <path
-          fill-rule="evenodd"
+          fillRule="evenodd"
           d="M12 5.25a.75.75 0 01.75.75v5.25H18a.75.75 0 010 1.5h-5.25V18a.75.75 0 01-1.5 0v-5.25H6a.75.75 0 010-1.5h5.25V6a.75.75 0 01.75-.75z"
-          clip-rule="evenodd"
+          clipRule="evenodd"
         />
       </svg>
     </button>

diff --git a/lib/lightning_web/live/workflow_live/edit.ex b/lib/lightning_web/live/workflow_live/edit.ex
@@ -472,11 +472,6 @@ defmodule LightningWeb.WorkflowLive.Edit do
 
       {:noreply,
        socket
-       |> push_patch(
-         to:
-           ~p"/projects/#{socket.assigns.project}/w/#{socket.assigns.workflow}",
-         replace: true
-       )
        |> apply_params(next_params)
        |> push_patches_applied(initial_params)}
     else

diff --git a/test/lightning_web/live/workflow_live/edit_test.exs b/test/lightning_web/live/workflow_live/edit_test.exs
@@ -285,8 +285,6 @@ defmodule LightningWeb.WorkflowLive.EditTest do
           %{op: "remove", path: "/edges/1"}
         ]
       })
-
-      assert_patched(view, ~p"/projects/#{project}/w/#{workflow}")
     end
 
     @tag role: :viewer