Skip to content

Commit

Permalink
Merge pull request #1011 from OpenFn/fix1010
Browse files Browse the repository at this point in the history
closes #1010
  • Loading branch information
taylordowns2000 authored Aug 2, 2023
2 parents e5838ed + 89c9c73 commit 3ee2486
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ and this project adheres to
first click. [#976](https://github.com/OpenFn/Lightning/issues/976)
- Return the pre-filled workflow names
[#971](https://github.com/OpenFn/Lightning/issues/971)
- Fix version reporting and external reset_demo() call via
Application.spec()[#1010](https://github.com/OpenFn/Lightning/issues/1010)

## [v0.7.0-pre5] - 2023-07-28

Expand Down
2 changes: 1 addition & 1 deletion config/runtime.exs
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ release =
else: image_tag

_other ->
"mix-v#{elem(:application.get_key(:lightning, :vsn), 1)}"
"mix-v#{Application.spec(:lightning, :vsn)}"
end

config :sentry,
Expand Down
2 changes: 1 addition & 1 deletion lib/lightning_web/live/components/common.ex
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ defmodule LightningWeb.Components.Common do
image = image_info[:image_tag]
branch = image_info[:branch]
commit = image_info[:commit]
vsn = "v#{elem(:application.get_key(:lightning, :vsn), 1)}"
vsn = "v#{Application.spec(:lightning, :vsn)}"

{display, message, type} =
cond do
Expand Down
4 changes: 2 additions & 2 deletions test/lightning_web/live/components/common_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ defmodule LightningWeb.Components.CommonTest do
prev = Application.get_env(:lightning, :image_info)

Application.put_env(:lightning, :image_info,
image_tag: "v#{elem(:application.get_key(:lightning, :vsn), 1)}",
image_tag: "v#{Application.spec(:lightning, :vsn)}",
branch: "main",
commit: "abcdef7"
)
Expand All @@ -27,7 +27,7 @@ defmodule LightningWeb.Components.CommonTest do

assert html =~ "Docker image tag found"
assert html =~ "tagged release build"
assert html =~ "v#{elem(:application.get_key(:lightning, :vsn), 1)}"
assert html =~ "v#{Application.spec(:lightning, :vsn)}"
end
end

Expand Down

0 comments on commit 3ee2486

Please sign in to comment.