Do Not Require Lock Version In URL Parameters (#2268)

* Do not pattern match on a query param * Update CHANGELOG.md --------- Co-authored-by: Taylor Downs <[email protected]>
OpenFn · Jul 10, 2024 · 86f3337 · 86f3337
1 parent 348c80b
commit 86f3337
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -21,6 +21,8 @@ and this project adheres to
 
 ### Fixed
 
+- Do Not Require Lock Version In URL Parameters
+  [#2267](https://github.com/OpenFn/lightning/pull/2267)
 - Trim erroneous spaces on user first and last names
   [#2269](https://github.com/OpenFn/lightning/pull/2269)
 

diff --git a/lib/lightning_web/live/workflow_live/edit.ex b/lib/lightning_web/live/workflow_live/edit.ex
@@ -920,11 +920,7 @@ defmodule LightningWeb.WorkflowLive.Edit do
     |> assign(page_title: "New Workflow")
   end
 
-  def apply_action(
-        socket,
-        :edit,
-        %{"id" => workflow_id, "v" => version} = params
-      ) do
+  def apply_action(socket, :edit, %{"id" => workflow_id} = params) do
     case socket.assigns.workflow do
       %{id: ^workflow_id} ->
         socket
@@ -943,6 +939,8 @@ defmodule LightningWeb.WorkflowLive.Edit do
 
         if workflow do
           run_id = Map.get(params, "a")
+          version = Map.get(params, "v") || workflow.lock_version
+
           snapshot = snapshot_by_version(workflow.id, version)
 
           socket