Skip to content

Commit

Permalink
Fix Projects Table Sorting Directions Icons (#2631)
Browse files Browse the repository at this point in the history
* Fix sorting direction icons
  • Loading branch information
elias-ba authored Nov 6, 2024
1 parent 890da73 commit c46c909
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ and this project adheres to

### Fixed

- Fix sorting directions icons in projects table in the project dashboard page
[#2631](https://github.com/OpenFn/lightning/pull/2631)
- Fixed an issue where code-completion prompts don't load properly in the
inspector [#2629](https://github.com/OpenFn/lightning/pull/2629)
- Fixed an issue where namespaces (like http.) don't appear in code assist
Expand Down
4 changes: 2 additions & 2 deletions lib/lightning_web/live/dashboard_live/components.ex
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ defmodule LightningWeb.DashboardLive.Components do
end

def user_projects_table(assigns) do
next_sort_icon = %{asc: "hero-chevron-down", desc: "hero-chevron-up"}
next_sort_icon = %{asc: "hero-chevron-up", desc: "hero-chevron-down"}

assigns =
assign(assigns,
Expand Down Expand Up @@ -210,7 +210,7 @@ defmodule LightningWeb.DashboardLive.Components do
<%= if project.last_activity do %>
<%= Lightning.Helpers.format_date(
project.last_activity,
"%d/%b/%Y %H:%M:%S"
"%d/%m/%Y %H:%M:%S"
) %>
<% else %>
No activity
Expand Down
4 changes: 2 additions & 2 deletions test/lightning_web/live/dashboard_live_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ defmodule LightningWeb.DashboardLiveTest do
)

formatted_date =
Lightning.Helpers.format_date(max_updated_at, "%d/%b/%Y %H:%M:%S")
Lightning.Helpers.format_date(max_updated_at, "%d/%m/%Y %H:%M:%S")

assert has_element?(
view,
Expand Down Expand Up @@ -374,7 +374,7 @@ defmodule LightningWeb.DashboardLiveTest do
|> Enum.max(fn -> nil end)

if last_activity do
Lightning.Helpers.format_date(last_activity, "%d/%b/%Y %H:%M:%S")
Lightning.Helpers.format_date(last_activity, "%d/%m/%Y %H:%M:%S")
else
"No activity"
end
Expand Down

0 comments on commit c46c909

Please sign in to comment.