Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP DNM] Per-Unit Execution #234

Draft
wants to merge 22 commits into
base: staging-execute-dag
Choose a base branch
from

Conversation

dwhswenson
Copy link
Member

@dwhswenson dwhswenson commented Sep 13, 2023

Opening as PR for better discussion with @dotsdl


Edit: This PR has been redirected so that it merges into #259. This allows you to only see the diffs specific to per-unit execution.

The original purpose of this PR (integrating with execute_DAG has been mainly moved into #258. As of #259, things should be enough in place that executors can update to use the new tools. The work left in this PR extends that to the draft the next generation of executors, where units can run in parallel on different machines.

@pep8speaks
Copy link

pep8speaks commented Nov 1, 2023

Hello @dwhswenson! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 10:1: E302 expected 2 blank lines, found 1

Line 14:1: E302 expected 2 blank lines, found 1
Line 32:1: E302 expected 2 blank lines, found 1
Line 38:1: E302 expected 2 blank lines, found 1
Line 72:1: E302 expected 2 blank lines, found 1

Comment last updated at 2023-12-01 19:47:40 UTC

@dwhswenson dwhswenson changed the base branch from shared-object-v2 to staging-serialization December 1, 2023 19:45
@dwhswenson dwhswenson changed the title [WIP DNM] Staging dirs in execute dag [WIP DNM] Per-Unit Execution Dec 1, 2023
Base automatically changed from staging-serialization to staging-execute-dag January 10, 2024 17:58
@richardjgowers richardjgowers self-assigned this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants