Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Games - Space Demo #129

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

AnkitaKhurana
Copy link
Member

Fixes issue: #124

Changes: Added a Space Shooting Game for the users.

image

@AdiChat
Copy link
Member

AdiChat commented Apr 30, 2018

Perfect work 😍

The option to access the rules of the games should appear on the game page (index.html). It can ,simply, be a button linking directly to the rules page (info.html).

Kindly make an appropriate change and it will be good to be merged. 👍

@AnkitaKhurana
Copy link
Member Author

Hi @AdiChat , are there any more changes required?

@AdiChat
Copy link
Member

AdiChat commented Jun 9, 2018

Looks good 😄

I have been thinking regarding the space requirements. No problem, we can integrate this game.
It will be nice if the game instructions are displayed in a modal on the same page and there exists a navigation bar on the top of the game page to aid user to go back to the homepage and keep a consistent look.

This will be good to be merged after the above minor changes. 👍

@AnkitaKhurana
Copy link
Member Author

Hi, @OpenGenus/contributors I am presently not working on this issue, it would be great if anyone can add the small fix required for the game integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants