Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use babel in the build process. #900

Merged
merged 4 commits into from
Aug 23, 2018
Merged

Use babel in the build process. #900

merged 4 commits into from
Aug 23, 2018

Commits on Aug 22, 2018

  1. Configuration menu
    Copy the full SHA
    77bcec4 View commit details
    Browse the repository at this point in the history
  2. Use babel 7 and babel polyfills.

    Babel 7 supports only adding polyfills for features that are used,
    resulting in a smaller bundle than babel 6.
    
    By using karma-phantomjs-shim and @babel/polyfills, we no longer need
    our own polyfills module.
    manthey committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    b21f208 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2018

  1. Use babel 6 and move where babel-polyfills are added.

    Babel 7 is still pending official release and causes some issues.  Babel
    7.0.0-rc.2 throws errors where 7.0.0-rc.1 does not.  Rather than figure
    out what causes these, I recommend we wait until it is officially
    released.  The main benefit of Babel 7 is that the polyfills can be
    added conditionally based on actual use.
    
    When adding babel-polyfill to src/index.js, the coverage for index.js is
    wrong (the line numbers are incorrect).  Further, babel-polyfill is
    fairly heavy, so just add it to the vendor.js (geo.js not geo.lean.js).
    It also needs to be added to the test-utils to ensure that we can use
    new language features in the tests with PhantomJS.  Reference to
    babel-polyfill has been moved to src/polyfills.js, and that file has
    been excluded from coverage analysis.
    
    For the coverage reporters, disable the html reporter as it fails with
    karma-coverage and babel.  One solution would be to switch to
    karma-coverage-istanbul-reporter, but I don't think the html coverage is
    strictly necessary as we use codecov.
    manthey committed Aug 23, 2018
    Configuration menu
    Copy the full SHA
    5c9c1d7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c303a85 View commit details
    Browse the repository at this point in the history