Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors populating invalid date error messages #182

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

1ec5
Copy link
Member

@1ec5 1ec5 commented Dec 5, 2023

Fixed a JavaScript error that prevented the full error message for invalid dates from appearing, and also one that prevented the suggested fix from being applied.

Before and after:

Before After

Fixes OpenHistoricalMap/issues#567.

@1ec5 1ec5 added the bug label Dec 5, 2023
@1ec5 1ec5 self-assigned this Dec 5, 2023
@danrademacher danrademacher merged commit 83092bc into staging Dec 12, 2023
2 checks passed
@1ec5 1ec5 deleted the 1ec5-invalid-date-fix-append-567 branch December 12, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error attempting to fix malformed date in iD
2 participants