Update style to latest

[danrademacher]

Pulled in the state of the map style as of this commit, OpenHistoricalMap/map-styles@5f0c7fd

This is part of diagnosing OpenHistoricalMap/issues#956 (comment)

[github-actions]

	1 Warning
⚠️	Number of updated lines of code is too large to be in one PR. Perhaps it should be separated into two or more?

Generated by 🚫 Danger

[danrademacher]

@erictheise this PR has the latest map style in it, which is the one to use as the base for expressions-dependent multilingual labels

[danrademacher]

@erictheise this PR patches in a fixed version of the latest Map Style where @tsinn resolved an issue that caused Ruben to roll back the map style.

The version of the style here is the same as the one at https://github.com/OpenHistoricalMap/map-styles/blob/staging/main/main.json, so if you are very close on implementing the NPM package method of deploying map styles, we could just ignore this PR. An NPM version of latest map-style would flow in and resolve this issue.

If NPM map style approach remains blocked by the RAILS_MASTER_Key, we could test and merge this PR and then I'd also change the map-style commit hash in ohm-deploy to get back on track with the map style.

We could plan that for next week, giving you some time to get the NPM map-styles approach resolved

[erictheise]

If NPM map style approach remains blocked by the RAILS_MASTER_Key, we could test and merge this PR and then I'd also change the map-style commit hash in ohm-deploy to get back on track with the map style.

We could plan that for next week, giving you some time to get the NPM map-styles approach resolved

@danrademacher, today's RAILS_MASTER_KEY issue was blocked a very simple deploy to staging–some translations and minor changes to JavaScript, JSON, and YML–and not the npm map-styles module work.

@1ec5 raised some concerns about legacy and other map projects that might be affected by changes in filenames and urls; they seem well-catalogued from an exercise last summer. The redirect solution makes sense to me but that would best be carried out by @Rub21 at the application server level (apache or nginx). I would like @tsinn and/or @vknoppkewetzel to weigh in on the impact of the proposed changes to their workflow.

I categorized the PRs as "draft" so that they wouldn't get merged until there was some discussion but the code works as is. I should rebase it against yesterday's c5cbd54b85fc6788159fd90f6c24e9a9a109ab26 but I'd like to see it on staging after OpenHistoricalMap/ohm-deploy#472 goes out, and shoot for getting it into production early next week. It is one of those deploys that I'd like to carve out some time for in case we find it needs a hotfix.

[danrademacher]

Ok, based on your last comment, I'm closing this PR in favor of OpenHistoricalMap/map-styles#32 (comment)

And I'm going to see about having Vanessa and Tim join our dev meeting on Tuesday.