Fixed the ctrl-c bug, Fixes #231 #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed the logic for establishing connection between client and server in Windows 11 |
|
Great to see these fixes. You should create a windows_11 branch on your fork so people could pull your fixes and test more rapidly. I did that with my Linux PRs: https://github.com/rbrisita/01/tree/linux |
|
Thank you for the suggestion, I have created the branch as requested and should be visible to anyone who wishes to utilize it. |
|
Love this, great work @Abdullah-Gohar. Windows support is an extremely high priority. (We're trying to test the 01-rewrite on Windows as much as Mac, to get full Windows support before the next update. That uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Ctrl-C on Windows and added alternate process kill utility for Windows.
Fixes #231