Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added blank ci #9

Merged
merged 4 commits into from
Apr 23, 2020
Merged

added blank ci #9

merged 4 commits into from
Apr 23, 2020

Conversation

alifiratari
Copy link
Contributor

CI: added blank yml file

@alifiratari
Copy link
Contributor Author

image

Copy link
Contributor

@zaya-mc zaya-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alifiratari Please do not fork the repo, instead please create a branch with the ticket number; T-3 in your case. (the GitHub Ticket ; "Discussion : Continuous Integration Tool #3")

Maybe it is just a test and not a proper Pull Request. If it is a proper pull request, please have a look at Development Guide ; https://github.com/OpenIoTAcademy/EmbeddedTemplate/blob/T-2/Documents/GitTutorial.md

Please see Commit Comment Convention section.

Thanks.

Comment on lines +8 to +10
branches: [ T-8 ]
pull_request:
branches: [ T-8 ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alifiratari Should they be "master" before we merge to master branch?

@@ -1,2 +1,4 @@
# EmbeddedTemplate
Template Project For Embedded Projects

![CI](https://github.com/alifiratari/EmbeddedTemplate/workflows/CI/badge.svg?branch=T-8)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What it is for? If it is required can you please add comments?

@zaya-mc
Copy link
Contributor

zaya-mc commented Apr 22, 2020

@alifiratari I have just merged T-8 branch to master, can you please rebase from master and update your CI script if it was dependent to T-8. Thanks.

@zaya-mc zaya-mc added this to the Preparation milestone Apr 22, 2020
@zaya-mc zaya-mc linked an issue Apr 22, 2020 that may be closed by this pull request
@alifiratari alifiratari force-pushed the T-8 branch 3 times, most recently from e31dcd7 to 7737d65 Compare April 23, 2020 22:13
ci: Added workflow for Coverity Scan
@alifiratari alifiratari merged commit 668cf78 into OpenIoTAcademy:T-8 Apr 23, 2020
zaya-mc added a commit that referenced this pull request May 6, 2020
* T-2 : SW Development Life Cycle Tutorial

* T-8 : Initial Makefile

* added blank ci

CI: added blank yml file

* ci: Added workflow for Coverity Scan

ci: Added workflow for Coverity Scan

Co-authored-by: Murat Cakmak <[email protected]>
Co-authored-by: Ali Firat ARI <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Tool : Github Action
3 participants