fix: remove misleading 'rm' error message (#10)

Problem:
 When running a Session as a different user on posix systems you will
see a benign, but misleading, error message in the log that looks like:
```
rm: cannot remove '/tmp/openjd/session-name': Permission denied
```

This is caused by our two-phase cleanup of the Session working
directory. We start with a cross-user 'rm -rf' to delete everything in
the directory, and then do a same-user recursive delete. So, the working
directory is getting cleaned up but there is this error in logs that is
misleading.

Solution:
 The `rm -rf` just needs to be changed to `rm -rf <dir>/*` from `rm -rf
<dir>`.

Signed-off-by: Daniel Neilson <[email protected]>

hatch.toml

@@ -31,3 +31,6 @@ build = "hatch build"
 
 [envs.codebuild.env-vars]
 PIP_INDEX_URL=""
+
+[envs.container.env-vars]
+

src/openjd/sessions/_session.py

@@ -373,7 +373,7 @@ def cleanup(self) -> None:
                     if os_name == "posix":
                         subprocess = LoggingSubprocess(
                             logger=self._logger,
-                            args=["rm", "-rf", str(self.working_directory)],
+                            args=["rm", "-rf", f"{str(self.working_directory)}/*"],
                             user=self._user,
                         )
                         # Note: Blocking call until the process has exited

testing_containers/ldap_sudo_environment/run_tests.sh

@@ -11,5 +11,5 @@ cd code
 python -m venv .venv
 source .venv/bin/activate
 pip install hatch
-# Use the codebuild env so that PIP_INDEX_URL isn't set in the hatch config files.
-hatch run codebuild:test
+# Use the container env so that PIP_INDEX_URL isn't set in the hatch config files.
+hatch run container:test

testing_containers/localuser_sudo_environment/run_tests.sh

@@ -11,5 +11,5 @@ cd code
 python -m venv .venv
 source .venv/bin/activate
 pip install hatch
-# Use the codebuild env so that PIP_INDEX_URL isn't set in the hatch config files.
-hatch run codebuild:test
+# Use the container env so that PIP_INDEX_URL isn't set in the hatch config files.
+hatch run container:test