fix: emit openjd_* log messages without any log formatting #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The adaptor runtime is currently printing
openjd_*
messages with log formatting enabled, meaning they are prefixed with the log level. This prevents these messages from being captured by OpenJD since they do not meet the spec of requiring the line start withopenjd_*
.This manifests in two ways:
on_*
methods (e.g.on_run
), we are currently emitting anERROR
level log message in theAdaptorRunner
class (code). Our log formatter will print this with anERROR:
prefix to the message.ADAPTOR_OUTPUT
. Our log formatter will print this with anADAPTOR_OUTPUT:
prefix to the messageWhat was the solution? (How)
Added a conditional log formatter which does not apply formatting to any log messages that begin with
openjd_*
What is the impact of this change?
Any
openjd_*
message emitted by the adaptor runtime will no longer have log formatting applied to it, allowing it to be captured by OpenJDHow was this change tested?
on_run
(logs below)Was this change documented?
No
Is this a breaking change?
No
E2E testing logs
BEFORE - Regular mode
AFTER - Regular Mode
BEFORE - Background Mode
AFTER - Background Mode
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.