refactor: Extract the adaptor handler logic to the AdaptorServerResponseGenerator. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nseGenerator. Signed-off-by: Hongli Chen <[email protected]>
Honglichenn
force-pushed
the
honglich/refactor_adaptor_server
branch
from
9210832
to
5bff1bf
Compare
AWS-Samuel
approved these changes
Nov 22, 2023
roblutt
approved these changes
Nov 27, 2023
Honglichenn
pushed a commit
that referenced
this pull request
Jan 17, 2024
Signed-off-by: Charles Moore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
During development of the Adaptor Server in Windows, I found there are lots of duplicate code, because the server will take the same action no matter in Linux or Windows.
What was the solution? (How)
Similar to previous PR: #20
Do some code refactoring in the Linux to extract the response logic to a new class
AdaptorServerResponseGenerator, so we can reuse those methods in both Windows and Linux.All integration tests are not changed, which means that this refactoring doesn't affect the behavior. I need to change some unit tests to mock
query_string_paramsin some tests.What is the impact of this change?
It should not have any impacts in Linux.
How was this change tested?
All tests are passed
Was this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.