refactor: Extract the Namedpipe Server creation logic to a common class NamedPipeServer. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Honglichenn
force-pushed
the
honglich/RefactorNamedPipe
branch
from
22960e2
to
f0254c2
Compare
Honglichenn
changed the title
…ss NamedPipeServer. Signed-off-by: Hongli Chen <[email protected]>
Honglichenn
force-pushed
the
honglich/RefactorNamedPipe
branch
from
f0254c2
to
70580a2
Compare
AWS-Samuel
approved these changes
Nov 30, 2023
roblutt
approved these changes
Nov 30, 2023
Honglichenn
pushed a commit
that referenced
this pull request
Jan 17, 2024
Signed-off-by: Robert Luttrell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
We will create the Named Pipe Server in two places, background mode and the Adaptor Server. In order to avoid duplicated code, I want to extract the common Named Pipe Server code to some shared classes.
What was the solution? (How)
Create a shared folder
_named_pipeand put the common code under it.What is the impact of this change?
It should not affect anything, it is just a code refactoring.
How was this change tested?
All tests are passed after refactoring.
Was this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.