refactor!: move submit out of the http_server.py
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: `submit` is removed from BackgroundHTTPServer Signed-off-by: Hongli Chen <[email protected]>
Honglichenn
force-pushed
the
honglich/linux_refactor
branch
from
6d86c7d
to
c47d9b4
Compare
Honglichenn
changed the title
submit out of the http_server.pysubmit out of the http_server.py
AWS-Samuel
reviewed
Dec 13, 2023
Signed-off-by: Hongli Chen <[email protected]>
roblutt
reviewed
Dec 14, 2023
roblutt
reviewed
Dec 14, 2023
Signed-off-by: Hongli Chen <[email protected]>
roblutt
approved these changes
Dec 14, 2023
AWS-Samuel
approved these changes
Dec 19, 2023
Honglichenn
pushed a commit
that referenced
this pull request
Jan 17, 2024
…37) Updates the requirements on [pytest-xdist](https://github.com/pytest-dev/pytest-xdist) to permit the latest version. - [Release notes](https://github.com/pytest-dev/pytest-xdist/releases) - [Changelog](https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest-xdist@v3.3.0...v3.5.0) --- updated-dependencies: - dependency-name: pytest-xdist dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The logic of the
submitinhttp_server.pyis duplicated, because we already move it to theserver_response.py.What was the solution? (How)
Delete it and rewrite some unit tests.
What is the impact of this change?
Nothing should be impacted.
How was this change tested?
Run all tests.
Was this change documented?
No.
Is this a breaking change?
Yes, because
submitis removed, but this should not affect any other packages.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.