Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimum package support 0A16 and 0A17 #3952

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Minimum package support 0A16 and 0A17 #3952

merged 1 commit into from
Jan 16, 2025

Conversation

ya4ept
Copy link
Contributor

@ya4ept ya4ept commented Jan 15, 2025

Fix: #3951

0A16 - CZ_DYNAMICNPC_CREATE_REQUEST
0A17 - PACKET_ZC_DYNAMICNPC_CREATE_RESULT

Added new command:

nc - NPC Create (default name is GOLDPCCAFE)
nc <name> - Create NPC by <name>

Examlpe:

help nc

==================================================== Help for 'nc' ====================================================
NPC Create.
nc           Create NPC by default name 'GOLDPCCAFE'
nc <name>    Create NPC by <name>
=======================================================================================================================

nc

================================================
>> Sent packet: 0A16  [NPC Dynamic Create Request] [26 bytes]   2025.01.16 01:49:53
  0>  16 0A 00 00 00 00 00 00    00 00 00 00 00 00 00 00    ................
 16>  00 00 00 00 00 00 00 00    00 00                      ..........
================================================
<< Received packet:      0A17 - NPC Dynamic Create Result [6 bytes]   2025.01.16 01:49:53
  0>  17 0A 02 00 00 00                                     ......
Dynamic NPC create result - Status: Unknown NPC

nc test
================================================
>> Sent packet: 0A16  [NPC Dynamic Create Request] [26 bytes]   2025.01.16 01:52:06
  0>  16 0A 00 00 00 00 00 00    00 00 00 00 00 00 00 00    ................
 16>  00 00 00 00 00 00 00 00    00 00                      ..........
================================================
<< Received packet:      0A17 - NPC Dynamic Create Result [6 bytes]   2025.01.16 01:52:06
  0>  17 0A 02 00 00 00                                     ......
Dynamic NPC create result - Status: Unknown NPC

I tested only one status "DYNAMICNPC_RESULT_UNKNOWNNPC":

# dynamicnpc_create_result
use constant {
	DYNAMICNPC_RESULT_SUCCESS => 0x0,
	DYNAMICNPC_RESULT_UNKNOWN => 0x1,
	DYNAMICNPC_RESULT_UNKNOWNNPC => 0x2,
	DYNAMICNPC_RESULT_DUPLICATE => 0x3,
	DYNAMICNPC_RESULT_OUTOFTIME => 0x4
};

@ya4ept
Minimum package support 0A16 and 0A17
5c38545 
0A16 - CZ_DYNAMICNPC_CREATE_REQUEST
0A17 - PACKET_ZC_DYNAMICNPC_CREATE_RESULT

Added new command:
nc - NPC Create (default name is GOLDPCCAFE)
nc <name> - Create NPC by <name>
@ya4ept ya4ept mentioned this pull request Jan 15, 2025
Closed
@ya4ept
Copy link
Contributor Author

ya4ept commented Jan 16, 2025 •
edited
Loading

@ya4ept ya4ept merged commit 174131c into master Jan 16, 2025
9 checks passed
@ya4ept ya4ept deleted the feature/add_0A16 branch January 16, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonrag alisonrag alisonrag approved these changes

Assignees
No one assigned
Labels
documentation feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Packet Parser: Unknown switch: 0A16
2 participants
@ya4ept @alisonrag