Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to combine cookie header #30069

Open
wants to merge 1 commit into
base: netty-transport-http
Choose a base branch
from

Conversation

mrsaldana
Copy link
Member

@mrsaldana mrsaldana commented Nov 5, 2024

HTTP requests containing multiple Cookie headers were not being processed correctly. According to RFC 6265, "the user agent MUST NOT attach more than one Cookie header field".

Netty's default behavior only considers the first Cookie header, leading to issues when multiple Cookie headers are present.

This PR adds a CombinedCookieHandler to intercept the FullHttpRequest and combine multiple Cookie headers.

@mrsaldana mrsaldana force-pushed the netty-transport-http-cookie-combiner branch from 02aef97 to e4484f0 Compare November 5, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant