Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first step toward using standard MPConfig property names #7794

Conversation

njr-11
Copy link
Contributor

@njr-11 njr-11 commented Jun 6, 2019

In order to align with standards being defined for MicroProfile specs that define their own MicroProfile Config properties, we need to change the name of 7 properties that MicroProfile Context Propagation uses to supply default values for ManagedExecutor/ThreadContext instances. Per eclipse/microprofile#100 these property names should be prefixed with mp.[spec-name]. and per eclipse/microprofile-config#420 these property names should avoid the use of /.

This pull will make OpenLiberty tolerate either form of the property names for now. Then, once the spec changes goes through, we can remove support for the old names.

@njr-11
Copy link
Contributor Author

njr-11 commented Jun 6, 2019

#build

@LibbyBot
Copy link

LibbyBot commented Jun 6, 2019

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 3 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 2 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

@LibbyBot
Copy link

LibbyBot commented Jun 6, 2019

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_NeetMIhpEem3a_lXnKb_ZA

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Jun 6, 2019

@njr-11 njr-11 merged commit 7bdfd5c into OpenLiberty:integration Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants