Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #8

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Develop #8

wants to merge 35 commits into from

Conversation

robert-1109
Copy link

@robert-1109 robert-1109 commented Feb 12, 2021

This PR is a:

  • New topic
  • Content update
  • Content fix or rewrite
  • Bug fix or improvement

Summary

I polished the presentation and structure of the documentation meaning e.g. updated wording to fit OpenMage purpose, fixing broken links or new coloring.

For new pages I used the jekyll theme devdoc provided by Adobe | Magento. (Possible to use just had to remove every logo of adobe or magento).
I recommend to use the theme with it's layouts and everything. It's responsive, good looking and modulare in comparison to the M1 reference styling.

  • Added updated System-Requirements page
  • Added Installation Flow Diagramm
  • Added Preqrequisites overview page
    • added Apache page
    • added PHP page
    • added MySQL page
  • Added Release Info page

I recolored links, buttons, text, icons and callouts to magenta and violet shades to fit OpenMage.
Changed the M1 reference style to make it somewhat responsive.

Additional information

List all affected URLs

  • index.html
  • /guides/m1x/...
  • index.html
  • whats-new.html
  • system-requirements.html

B3 IT and others added 28 commits November 19, 2020 16:16
renamed folders, metadata
Heading and text was overflowing sidebar
fixed some files from previous commit
renamed folders, metadata
…s which were missed

Heading and text was overflowing sidebar

 Updating nameing  to match current standards

 fixed some files from previous commit
…er in page-info,created introduction to extension guide
renamed folders, metadata
fixed some files from previous commit
…s and changed guide path piece in links to variable
… theme to fit OpenMage; Changed favicon/icons to openmage
… (header and headerscripts); changed some phrasing and fixed link to install guide; created php-extension include containing list of necessary php extensions
@luigifab
Copy link

luigifab commented Feb 3, 2022

Do you have an online demo of your changes?

@fballiano
Copy link
Contributor

@Flyingmana what are we doing about this one?

@Flyingmana
Copy link
Contributor

@Flyingmana what are we doing about this one?

we would need a volunteer with a bit of knowledge about jekyll and github pages to check and review this, or we just merge it and see how it goes

@fballiano
Copy link
Contributor

what if we merge it, check it, worse case we revert it?

@Flyingmana
Copy link
Contributor

thats one way forward. Would be okay for me

@colinmollenhour
Copy link
Member

Were all of the line endings changed? Would be much easier to review if they weren't... but no objection from me on merging and seeing what happens. :)

* [2.0.x system requirements]({{ site.gdeurl }}install-gde/system-requirements.html)
* [2.1.x system requirements]({{ site.gdeurl21 }}install-gde/system-requirements-tech.html)
* [2.2.x system requirements]({{ site.gdeurl22 }}install-gde/system-requirements-tech.html)
2. Get the Magento LTS software.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Get the Magento LTS software.
2. Get OpenMage.

2. Get the Magento software.
* Download the latest archive and extract it, clone the repo, or add a composer dependency to your existing project like so:
```json
"openmage/magento-lts": "1.9.4.x"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong for sure nowadays

Comment on lines +1 to +4
Magento LTS supports PHP 7.3.

{:.bs-callout-warning}
PHP 7.1 has reached [End of Life](https://www.php.net/supported-versions.php). To maintain PCI compliance, Magento should not be run on unsupported software.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of this info is now outdated :-(

Copy link
Contributor

@Flyingmana Flyingmana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say we merge and fix afterwards

@fballiano
Copy link
Contributor

without a demo I've no idea of the results of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants