-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified admin grid columns #4225
base: main
Are you sure you want to change the base?
Conversation
If we fix this problem, all the grids in the Backend will have to be revised. For example, the Manage Customers grid, we are allowed to input strings on the ID column for the From and To inputs. |
Yes, i know, but please not here in this PR. Better make small steps ... edit: Pls collect all the grids that need changes, make new issue and we move on. |
@sreichel - This is the grids list which have columns that allow searching strings and return zero as results. In order to check I had to change records in the database. I hope I did not miss anything. This PR solves only one of the issues Catalog > Products - Price column. Sales > Orders
Sales > Invoices
Sales > Shipments
Sales > Credit Memos
Sales > Tax > Manage Tax Zone & Rates
Catalog > Products
Catalog > Products > Edit Product > Related Products tab
Catalog > Products > Edit Product > Up-sells Products tab
Catalog > Products > Edit Product > Cross-sells Products tab
Catalog > Products > Edit Product > Product Tags tab
Catalog > Products > Edit Product > Associated Products tab (configurable)
Catalog > Categories > Category Products tab
Catalog > Search Terms
Promotions > Shopping Cart Price Rules
Newsletter > Newsletter Queue
Newsletter > Newsletter Problem Reports
Reports > Shopping Cart > Abandoned carts
Reports > Producs > Low stock
Reports > Search Terms
|
- makes all "entity_id" grid columns searchable "from" "to" - disallow/ignore non-numeric input on price/currency/range grid columns - removed useless "'sortable' => true"
Description (*)
entity_id
grid columns searchablefrom
to
"'sortable' => true"
return parent::renderCss() . ' a-right';
(*) Note: instead of having zero results, as suggested in mentioned issue, it will ignore input and return all products.
Fixed Issues (if relevant)